[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189075#comment-17189075 ]
Uwe Schindler commented on SOLR-14579: -------------------------------------- Hi Erick, why did you re-apply the 8.x comments? They are as wrong as in master. If you read my explanation: Those are non-capturing lambdas so they dont prodcute instances. This is explained in Brian Goetz's technical document (from April 2012), and applies even to earliest Java 8 versions. The PR removing the static funtions in Java is correct in any Java version (8,11). > Comment SolrJ 'Utils' generic map functions > ------------------------------------------- > > Key: SOLR-14579 > URL: https://issues.apache.org/jira/browse/SOLR-14579 > Project: Solr > Issue Type: Improvement > Affects Versions: master (9.0) > Reporter: Megan Carey > Assignee: Erick Erickson > Priority: Minor > Fix For: 8.7 > > Attachments: SOLR-14579.patch > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Remove the map functions like `NEW_HASHMAP_FUN` from the Utils class in solrj > module to reduce warnings and improve code quality. > [https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Utils.java#L92] -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org