jpountz commented on a change in pull request #1789:
URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482418961
##########
File path:
lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java
##########
@@ -165,4 +166,62 @@ public long longValue() {
return value;
}
}
+
+ static class SortingNumericDocValues extends NumericDocValues {
+
+ private final CachedNumericDVs dvs;
+ private int docID = -1;
+
+ SortingNumericDocValues(CachedNumericDVs dvs) {
+ this.dvs = dvs;
+ }
+
+ @Override
+ public int docID() {
+ return docID;
+ }
+
+ @Override
+ public int nextDoc() {
+ if (docID+1 == dvs.docsWithField.length()) {
+ docID = NO_MORE_DOCS;
+ } else {
+ docID = dvs.docsWithField.nextSetBit(docID+1);
+ }
+
+ return docID;
+ }
+
+ @Override
+ public int advance(int target) {
+ docID = dvs.docsWithField.nextSetBit(target);
+ return docID;
+ }
+
+ @Override
+ public boolean advanceExact(int target) throws IOException {
+ docID = target;
+ return dvs.docsWithField.get(target);
Review comment:
throw UOE here too?
##########
File path:
lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java
##########
@@ -165,4 +166,62 @@ public long longValue() {
return value;
}
}
+
+ static class SortingNumericDocValues extends NumericDocValues {
+
+ private final CachedNumericDVs dvs;
+ private int docID = -1;
+
+ SortingNumericDocValues(CachedNumericDVs dvs) {
+ this.dvs = dvs;
+ }
+
+ @Override
+ public int docID() {
+ return docID;
+ }
+
+ @Override
+ public int nextDoc() {
+ if (docID+1 == dvs.docsWithField.length()) {
+ docID = NO_MORE_DOCS;
+ } else {
+ docID = dvs.docsWithField.nextSetBit(docID+1);
+ }
+
+ return docID;
+ }
+
+ @Override
+ public int advance(int target) {
+ docID = dvs.docsWithField.nextSetBit(target);
+ return docID;
+ }
+
+ @Override
+ public boolean advanceExact(int target) throws IOException {
+ docID = target;
+ return dvs.docsWithField.get(target);
+ }
+
+ @Override
+ public long longValue() {
+ return dvs.values[docID];
+ }
+
+ @Override
+ public long cost() {
+ return dvs.docsWithField.cardinality();
Review comment:
and cache the cost?
##########
File path:
lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java
##########
@@ -202,4 +203,63 @@ public BytesRef binaryValue() {
return value.get();
}
}
+
+ static class SortingBinaryDocValues extends BinaryDocValues {
+ private final CachedBinaryDVs dvs;
+ private int docID = -1;
+ private long cost = -1;
+
+ SortingBinaryDocValues(CachedBinaryDVs dvs) {
+ this.dvs = dvs;
+ }
+
+ @Override
+ public int nextDoc() {
+ if (docID+1 == dvs.docsWithField.length()) {
+ docID = NO_MORE_DOCS;
+ } else {
+ docID = dvs.docsWithField.nextSetBit(docID+1);
+ }
+ return docID;
+ }
+
+ @Override
+ public int docID() {
+ return docID;
+ }
+
+ @Override
+ public int advance(int target) {
+ throw new UnsupportedOperationException("use nextDoc instead");
+ }
+
+ @Override
+ public boolean advanceExact(int target) throws IOException {
+ throw new UnsupportedOperationException("use nextDoc instead");
Review comment:
I just realized reading other comments that this method might be
required when configuring index sorting on a binary field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
