vthacker commented on pull request #1816:
URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686719941
> but I'd like to see how to mark valid code with suppressions first so that
we can correct the errors, exclude false-positives somehow and then enable this
plugin to run by default.
Instead of marking code with supressions, what if we excluded all the
warning types that are there in our codebase explicitly
```
options.errorprone.errorproneArgs = ['-Xep:ClassCanBeStatic:OFF',
'-Xep:InvalidInlineTag:OFF', ....
```
That would ensure
1. No new warnings creep in
1. We don't need to remove `-Werror` and the compile output doesn't throw a
bunch of warnings that no one looks at
Then in subsequent PRs we can remove one warning type and fix the code usage
by either addressing them or suppressing them in code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
