murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483590300
########## File path: solr/core/src/java/org/apache/solr/cluster/scheduler/impl/SolrSchedulerImpl.java ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cluster.scheduler.impl; + +import java.lang.invoke.MethodHandles; +import java.time.Instant; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; + +import org.apache.solr.cloud.ClusterSingleton; +import org.apache.solr.cluster.scheduler.Schedule; +import org.apache.solr.cluster.scheduler.Schedulable; +import org.apache.solr.cluster.scheduler.SolrScheduler; +import org.apache.solr.common.util.SolrNamedThreadFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * <p>Scheduled executions are triggered at most with {@link #SCHEDULE_INTERVAL_SEC} interval. + * Each registered {@link Schedulable} is processed sequentially and if its next execution time + * is in the past its {@link Schedulable#run()} method will be invoked. + * <p>NOTE: If the total time of execution of all registered Schedulable-s exceeds any schedule + * interval then exact execution times will be silently missed.</p> + */ +public class SolrSchedulerImpl implements SolrScheduler, ClusterSingleton { + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + public static final int SCHEDULE_INTERVAL_SEC = 10; Review comment: Instead of polling for tasks to run every 10 seconds could we be smart and set the next execution time of the scheduler to when the next job needs to be run? Is it worth the additional investment? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
