uschindler commented on a change in pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#discussion_r484229443
##########
File path:
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java
##########
@@ -191,9 +220,21 @@ private Expression compileExpression(ClassLoader parent)
throws ParseException {
try {
generateClass(getAntlrParseTree(), classWriter, externalsMap);
-
- final Class<? extends Expression> evaluatorClass = new Loader(parent)
- .define(COMPILED_EXPRESSION_CLASS, classWriter.toByteArray());
+
+ final Class<? extends Expression> evaluatorClass;
Review comment:
I was thinking about that, but as it throws a checked Exception it would
need a new functional interface. I moved the whole stuff to a separate method
`defineClass()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
