ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-693000958
So, the changes look fine enough to me, but I don't think they're actually needed. The `%autowidth.spread` works by setting a `spread` class on the <table> element. This is the default, though, so it's set even without defining that attribute. The way it has been with `cols="30,70"`, or whatever it was for each table, overrode that by setting the `<colgroup>` element on each table to set the width of each column. I suspect if you just remove the `cols` parameter and TODO note, the table will look pretty close the way it does with the new `autospread` attribute. I figured this out by inspecting the HTML for tables that had been created after the conversion from Confluence (when these TODOs were introduced), such as the one on `aliases.adoc`, which don't have the TODO. I noticed that it gets `<table class="spread">` (plus some other classes) and the `<colgroup>` is set to an equal % for each column. Which is basically which happens with the change here. It's also possible to avoid setting an explicit `options="header"` if all tables include an empty line between the first row and the subsequent rows. I'll leave that up to individual preference, though - the table in `aliases.adoc` does that, but others may not know to do that so an example of explicitly setting the header row isn't a negative. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
