thelabdude commented on a change in pull request #1938:
URL: https://github.com/apache/lucene-solr/pull/1938#discussion_r498916106
##########
File path: solr/core/src/java/org/apache/solr/rest/RestManager.java
##########
@@ -326,44 +327,46 @@ public void doInit() throws ResourceException {
}
}
}
-
+
if (managedResource == null) {
- if (Method.PUT.equals(getMethod()) || Method.POST.equals(getMethod()))
{
+ final String method = getSolrRequest().getHttpMethod();
+ if ("PUT".equals(method) || "POST".equals(method)) {
Review comment:
String equals unsafe? Not sure I understand what this warning is trying
to convey?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
