madrob edited a comment on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-703715598
> Are we sure we need dependency at all. I would have assumed that Gradle has it already. Gradle has a shaded commons codec that we can use - `org.gradle.internal.impldep.org.apache.commons.codec.digest.DigestUtils` - but I assumed that would be frowned upon. > This is also a forbiddenapis violation: the charset is missing. Please use: setText(..., "UTF-8") This didn't fail on precommit for me, can you do a follow on issue to apply forbiddenAPI to the gradle files? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
