[
https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-14914:
------------------------------------
Description:
Some users have expressed concerns about the overhead of metrics collection,
and consequently the need to have an option to turn off the metrics collection
altogether.
Metrics instrumentation in Solr cannot be itself easily removed or bypassed -
in order to provide fine-grained metrics many code paths had to be changed and
they now expect the metrics to be present (non-null). However, we can use the
mechanism of {{MetricSupplier}} to provide singleton no-op implementations of
all metrics, which would reduce the CPU overhead to basically the cost of an
empty method call, and the memory overhead to a HashMap entry in a
{{MetricRegistry}} (metric names still need to be tracked).
was:
Some users have expressed concerns about the overhead of metrics collection,
and consequently the need to have an option to turn off the metrics collection
altogether.
Metrics instrumentation in Solr cannot be itself easily removed or bypassed -
in order to provide fine-grained metrics many code paths had to be changed and
they now expect the metrics to be present (non-null). However, we can use the
mechanism of {{MetricSupplier}} to use no-op implementation of all metrics,
which would reduce the CPU overhead to basically the cost of an empty method
call, and the memory overhead to a HashMap entry in a {{MetricRegistry}}
(metric names still need to be tracked).
> Add option to disable metrics collection
> ----------------------------------------
>
> Key: SOLR-14914
> URL: https://issues.apache.org/jira/browse/SOLR-14914
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: 8.7
>
>
> Some users have expressed concerns about the overhead of metrics collection,
> and consequently the need to have an option to turn off the metrics
> collection altogether.
> Metrics instrumentation in Solr cannot be itself easily removed or bypassed -
> in order to provide fine-grained metrics many code paths had to be changed
> and they now expect the metrics to be present (non-null). However, we can use
> the mechanism of {{MetricSupplier}} to provide singleton no-op
> implementations of all metrics, which would reduce the CPU overhead to
> basically the cost of an empty method call, and the memory overhead to a
> HashMap entry in a {{MetricRegistry}} (metric names still need to be tracked).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
