mayya-sharipova edited a comment on pull request #1943: URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914
@jpountz Sorry for the noise, I have found the cause of this error, and the latest commit addresses it. Basically this PR will just address the failing test of `TestUnifiedHighlighterStrictPhrases.testBasics`. My next steps will the following: Plan A: - use leap-frog logic without using ConjunctionDISI for this method (a separate PR for that) - Then reintroduce again checks in [ConjunctionDISI](https://github.com/apache/lucene-solr/pull/1937) that I reverted Plan B: - continue to use ConjunctionDISI to combine scorerIterator and collectorIterator - from checks in [ConjunctionDISI](https://github.com/apache/lucene-solr/pull/1937) keep only the check on the same doc during constructor and remove all other checks, as sort optimization by introducing new DISI (from -1 doc) in the middle of iteration would break these checks. I am interested in your opinion which plan is better? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
