arafalov commented on pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-704656780
Ok, I reverted back to using direct styles. It only affects code-blocks, so the size changes are minimal and not needing to maintain the CSS file is a bonus. I agree. Looking at generated code, the only differences I see is some additional highlighting of options and changing in order of code/pre html elements which seems to sometimes lead to removal of one level of pre/code (I suspect it was a bug before). The warning about Lexer#lex is with source,php blocks in the file, due to asciidoctor/asciidoctor#3336, fixed in the master (not yet released). We can either ignore it or switch formatting for those two blocks to text. I think ignoring it is fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
