arafalov commented on a change in pull request #1923:
URL: https://github.com/apache/lucene-solr/pull/1923#discussion_r495891765
##########
File path: solr/solr-ref-guide/src/_config.yml.template
##########
@@ -91,6 +91,11 @@ asciidoctor:
<<: *solr-attributes-ref
attribute-missing: "warn"
icons: "font"
- source-highlighter: "rouge"
- rouge-theme: "thankful-eyes"
stem:
+ source-highlighter: "rouge"
+ # Options from: https://github.com/jirutka/asciidoctor-rouge
+ rouge-css: "class"
+ # class option requires css file generated by
build/.gems/gems/rouge-vx.y.z/bin/rougify style style_name
+ # other option: style for inline styles, which is larger in size
+ # rouge-css: "style"
+ # rouge-style: "github"
Review comment:
The styles generated for the source blocks (highlights) can be inlined
or in a separate css, which needs to be generated. Due to the support for - I
guess - dark mode - the inline styles make the documents somewhat larger. So,
CSS looked like a better option.
Also, the previous style was spelled incorrectly and therefore falling-back
to default style. I've just made of this explicit after spending time trying to
figure out the actual situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
