madrob commented on a change in pull request #1974:
URL: https://github.com/apache/lucene-solr/pull/1974#discussion_r504767202
##########
File path: solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java
##########
@@ -110,19 +110,22 @@
public static final int DEFAULT_CLOUD_REPORTER_PERIOD = 60;
- private MetricRegistry.MetricSupplier<Counter> counterSupplier;
- private MetricRegistry.MetricSupplier<Meter> meterSupplier;
- private MetricRegistry.MetricSupplier<Timer> timerSupplier;
- private MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
+ private final MetricsConfig metricsConfig;
+ private final MetricRegistry.MetricSupplier<Counter> counterSupplier;
+ private final MetricRegistry.MetricSupplier<Meter> meterSupplier;
+ private final MetricRegistry.MetricSupplier<Timer> timerSupplier;
+ private final MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
public SolrMetricManager() {
+ metricsConfig = new MetricsConfig.MetricsConfigBuilder().build();
counterSupplier = MetricSuppliers.counterSupplier(null, null);
meterSupplier = MetricSuppliers.meterSupplier(null, null);
Review comment:
(But it is still wrong in this case)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
