noblepaul commented on a change in pull request #1964:
URL: https://github.com/apache/lucene-solr/pull/1964#discussion_r505123274
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -168,6 +172,33 @@ public CoreLoadFailure(CoreDescriptor cd, Exception
loadFailure) {
}
}
+ public static class ClusterSingletons {
Review comment:
>That's the downside of splitting this PR into API & implementation ..
I thouh this Pr has both API and impl
`CC.load()` is a kitchen sink today. We should not need such large changes
to CC everytime something is added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
