TomMD commented on a change in pull request #1997:
URL: https://github.com/apache/lucene-solr/pull/1997#discussion_r508034442
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -415,19 +415,15 @@ private void fetchIndex(SolrParams solrParams,
SolrQueryResponse rsp) throws Int
}
static Long getCheckSum(Checksum checksum, File f) {
- FileInputStream fis = null;
checksum.reset();
byte[] buffer = new byte[1024 * 1024];
int bytesRead;
- try {
- fis = new FileInputStream(f);
+ try (final FileInputStream fis = new FileInputStream(f)) {
while ((bytesRead = fis.read(buffer)) >= 0)
checksum.update(buffer, 0, bytesRead);
return checksum.getValue();
} catch (Exception e) {
Review comment:
@madrob Oh I see. It seems quite likely that Infer doesn't understand
try-with-resources (and yes, I missed it in my glance at the code). So this is
a false positive for that reason. Thank you, I'll run with this example to try
and get things cleaned up.
In general there does exist some level of false positives. We're working
hard to get and keep those quite minimal. Everyone is encouraged to use the
'resolve' button and we are simultaneously working on a command system so you
can state "ignore" to get to bot to resolve and adjust the analysis. Thanks
again for noting this instance, we will use it to learn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
