mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518799913
########## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ########## @@ -218,7 +237,7 @@ public void visit(int docID, byte[] packedValue) { @Override public DocIdSetIterator competitiveIterator() { - if (enableSkipping == false) return null; + if (enableSkipping == false && indexSort == false) return null; Review comment: Addressed in c52d9a7. I also have a plan to a do a separate PR to just fix formatting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org