dweiss commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r519618160
########## File path: lucene/native/build.gradle ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/* + * This gets separated out from misc module into a native module due to incompatibility between cpp-library and java-library plugins. + * For details, please see https://github.com/gradle/gradle-native/issues/352#issuecomment-461724948 + */ +apply plugin: 'cpp-library' + +description = 'Module for native code' + +library { + baseName = 'NativePosixUtil' + + privateHeaders.from file(System.getProperty('java.home') + '/include') + privateHeaders.from file(System.getProperty('java.home') + '/include/darwin') + privateHeaders.from file(System.getProperty('java.home') + '/../include/solaris') Review comment: These paths are wrong, I think. I don't know where they came from but they should correspond to the layout of newer JDK distributions (openjdk). I'm not sure Solaris is still needed - I can't test it on Solaris. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
