jpountz commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520034757
##########
File path:
lucene/core/src/test/org/apache/lucene/codecs/lucene80/BaseLucene80DocValuesFormatTestCase.java
##########
@@ -286,7 +278,7 @@ private void doTestTermsEnumRandom(int numDocs,
Supplier<String> valuesProducer)
conf.setMergeScheduler(new SerialMergeScheduler());
// set to duel against a codec which has ordinals:
final PostingsFormat pf = TestUtil.getPostingsFormatWithOrds(random());
- final DocValuesFormat dv = new Lucene80DocValuesFormat();
+ final DocValuesFormat dv = getCodec().docValuesFormat();
Review comment:
It's not randomizing, we are testing both modes explicitly via
TestBestSpeedLucene80DocValuesFormat on one hand and
TestBestCompressionLucene80DocValuesFormat on the other hand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
