jpountz commented on a change in pull request #2069:
URL: https://github.com/apache/lucene-solr/pull/2069#discussion_r520035432
##########
File path:
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene87/Lucene87Codec.java
##########
@@ -56,6 +57,23 @@
* @lucene.experimental
*/
public class Lucene87Codec extends Codec {
+
+ /** Configuration option for the codec. */
+ public static enum Mode {
+ /** Trade compression ratio for retrieval speed. */
+ BEST_SPEED(Lucene87StoredFieldsFormat.Mode.BEST_SPEED,
Lucene80DocValuesFormat.Mode.BEST_SPEED),
+ /** Trade retrieval speed for compression ratio. */
+ BEST_COMPRESSION(Lucene87StoredFieldsFormat.Mode.BEST_COMPRESSION,
Lucene80DocValuesFormat.Mode.BEST_COMPRESSION);
+
+ private final Lucene87StoredFieldsFormat.Mode storedMode;
+ private final Lucene80DocValuesFormat.Mode dvMode;
+
+ private Mode(Lucene87StoredFieldsFormat.Mode storedMode,
Lucene80DocValuesFormat.Mode dvMode) {
Review comment:
Right. It's still possible to made different choices for stored fields
and doc values given that we allow configuration of doc values on a per-field
basis, but this should at least keep simple use simple with one switch that
configures stored fields and doc values at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
