dweiss commented on a change in pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r523804321
########## File path: gradle/native/disable-native.gradle ########## @@ -17,20 +17,65 @@ // This is the master switch to disable all tasks that compile // native (cpp) code. -def buildNative = propertyOrDefault("build.native", true).toBoolean() +rootProject.ext { + buildNative = propertyOrDefault("build.native", true).toBoolean() +} + +// Explicitly list all projects that should be configured for native extensions. +// We could scan for projects with a the cpp-library plugin but this is faster. +def nativeProjects = allprojects.findAll {it.path in [ + ":lucene:misc:native" +]} + +def javaProjectsWithNativeDeps = allprojects.findAll {it.path in [ + ":lucene:misc" +]} + +// Set up defaults for projects with native dependencies. +configure(javaProjectsWithNativeDeps, { + configurations { Review comment: Yep, I think it's ready! Please monitor jenkins so that we know should something go wrong - if it does we can just turn native builds off (by default). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org