mikemccand commented on pull request #2088: URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-735405583
Great, thank you for adding the new "user space impact" test case @msfroh (in addition to the low-level unit test)! @dsmiley does that address your concern about the lower level unit test? Net/net I think this is ready -- I think the existing tests we have that concurrently {{deleteAll}} help address @rmuir's concern too. I will beast this change for a while to see if there are any interesting failures ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org