mikemccand commented on pull request #2088: URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-731398054
OK thanks @msfroh. This indeed sounds like a very inefficient way to test for this particular bug! But maybe you could mark it `@Monster`, like e.g. `Test2BBinaryDocValues` and such? These tests get run only during release (if even, hmm). I think it is out of scope for you to prove, here, that usage of this `FieldInfos.clear()` API is 100% safe -- we cannot boil the ocean with otherwise well contained bug fixes like this one. Progress not perfection :) Maybe we can at least add a warning to javadocs for `IndexWriter.deleteAll` that any concurrently running indexing operations (`addDocument`, etc.) may or may not be deleted, i.e. the behavior of such concurrent operations are not defined / predictable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
