dweiss commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r534851417
##########
File path: lucene/misc/native/build.gradle
##########
@@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach {
// is present.
systemIncludes.from file("${javaHome}/include")
- for (def path : [
Review comment:
I'd leave it in as it was (multiplatform includes, conditionally) -
doesn't hurt even if we only compile on a single platform and may save somebody
some head-scratching in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
