[ 
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243107#comment-17243107
 ] 

Adrien Grand commented on LUCENE-9619:
--------------------------------------

The difference between what I'm proposing and the current API is that the 
intersect methods only look at data that is below the current node. So it 
should be possible to use the moveTo* methods to walk the tree in depth-first 
order and only call intersect* on the leaf nodes?

 My main concern about reusing DocIdSetIterator is that this requires sorting 
doc IDs since this si part of the contract of DocIdSetIterator. However I like 
your idea of using a predicate so maybe {{void intersect(IntersectVisitor 
visitor)}} could become {{void intersect(Predicate<byte[]> predicate, 
IntConsumer visitor)}}?

> Move Points from a visitor API to a custor-style API?
> -----------------------------------------------------
>
>                 Key: LUCENE-9619
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9619
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>
> Points' visitor API work well but there are a couple things we could make 
> better if we moved to a cursor API, e.g.
>  - Term queries could return a DocIdSetIterator without having to materialize 
> a BitSet.
>  - Nearest-neighbor search could work on top of the regular API instead of 
> casting to BKDReader 
> https://github.com/apache/lucene-solr/blob/6a7131ee246d700c2436a85ddc537575de2aeacf/lucene/sandbox/src/java/org/apache/lucene/sandbox/document/FloatPointNearestNeighbor.java#L296
>  - We could optimize counting the number of matches of a query by adding the 
> number of points in a leaf without visiting documents where there are no 
> deleted documents and a leaf fully matches the query.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to