[ 
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244635#comment-17244635
 ] 

Tomoko Uchida commented on LUCENE-9623:
---------------------------------------

I just wanted to make things a bit clearer. To me, there are several open 
questions to be solved/answered.
 - What packages are exported and what are kept private - and how do we make 
the decision or get consensus about it (upon such a large codebase)?
 - How do we test if the modularized jars correctly work?
 - How do we integrate module system into our gradle build?

These matters are closely interwined, I don't think we can resolve them all at 
once. We'd need to start from somewhere...

> Add module descriptor (module-info.java) to lucene jars
> -------------------------------------------------------
>
>                 Key: LUCENE-9623
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9623
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: master (9.0)
>            Reporter: Tomoko Uchida
>            Priority: Major
>         Attachments: generate-all-module-info.sh
>
>
> For a starter, module descriptors can be automatically generated by jdeps 
> utility.
> There are two choices.
> 1. generate "open" modules which allows reflective accesses with 
> --generate-open-module option
> 2. generate non-open modules with --generate-module-info option
> Which is the better - not fully sure, but maybe 2 (non-open modules)?
> Also, we need to choose proper module names - just using gradle project path 
> for it is OK?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to