magibney commented on a change in pull request #2123:
URL: https://github.com/apache/lucene-solr/pull/2123#discussion_r537551055
##########
File path: solr/core/src/java/org/apache/solr/request/SimpleFacets.java
##########
@@ -325,6 +329,9 @@ public void getFacetQueryCount(ParsedParams parsed,
NamedList<Integer> res) thro
* @see FacetParams#FACET_QUERY
*/
public int getGroupedFacetQueryCount(Query facetQuery, DocSet docSet) throws
IOException {
+ if (docSet.size() == 0) {
+ return 0;
+ }
Review comment:
Both callers of this method (`SimpleFacets.getFacetQueryCount(...)` and
`RangeFacetProcessor.rangeCount(...)` check for the base `docSet.size()==0`
case independently. Could perhaps remove this redundant check (or replace with
`assert docSet.size() > 0`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
