magibney commented on a change in pull request #2123:
URL: https://github.com/apache/lucene-solr/pull/2123#discussion_r537501831
##########
File path: solr/core/src/java/org/apache/solr/search/facet/FacetProcessor.java
##########
@@ -419,7 +419,7 @@ void fillBucket(SimpleOrderedMap<Object> bucket, Query q,
DocSet result, boolean
}
count = result.size(); // don't really need this if we are skipping,
but it's free.
} else {
- if (q == null) {
+ if (q == null || fcontext.base.size() == 0) {
Review comment:
The query is already built at this point, so I don't think this
particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case
is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
