dweiss commented on pull request #2104: URL: https://github.com/apache/lucene-solr/pull/2104#issuecomment-744357731
Sorry, I missed this one. I think the includes approach is actually safer - people use all kinds of IDEs, tools and stuff that produces local files which you simply can't predict. If something is omitted in the distribution should be caught by ITs (which, admittedly we don't have in Solr). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
