[ https://issues.apache.org/jira/browse/LUCENE-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260760#comment-17260760 ]
ASF subversion and git services commented on LUCENE-9658: --------------------------------------------------------- Commit 8b4b1910c9af2d4303a53d4a6727d0e33178fea5 in lucene-solr's branch refs/heads/master from Michael Sokolov [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8b4b191 ] LUCENE-9658: add spotless formatting check to github precommit action > Make 'precommit' an alias for gradle 'check' task. > -------------------------------------------------- > > Key: LUCENE-9658 > URL: https://issues.apache.org/jira/browse/LUCENE-9658 > Project: Lucene - Core > Issue Type: Task > Reporter: Dawid Weiss > Assignee: Dawid Weiss > Priority: Major > > A separate precommit task is clumsy and error prone. This was done to support > back-compatibility with ant but I think it should be removed in favor of the > gradle-convention 'check'. > The only difference precommit currently has from check is that it doesn't run > tests. People who want to bypass tests can still run check with: > {code} > ./gradlew check -x test > {code} > which excludes all test tasks from running. > We can make precommit an alias to check at first ({{precommit.dependsOn > check}}) and perhaps disable all tests manually so that it is compatible with > the previous behavior. I'll add an info-box at the end to instruct people how > to run check without tests too. > The benefit of using check is that you can run it selectively on subprojects > and that there is no need for extra plumbing to attach validation tasks to it. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org