gerlowskija edited a comment on pull request #2183:
URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-756877504
> If the client side doesn't change, then does that mean this is safe to
back port to 8x?
Sorry, I think a comment I made above was misleading. This PR as a whole
will change the deserialized NamedList response structures that SolrJ users get
back. Which makes this approach tough to backport as-is. I do intend to
commit a branch_8x fix to workaround the ClassCastException on the client side,
but that'll be a different approach.
My comment above that starts "This changes the object used on the server
side [only] ..." was intended to address in advance a question I thought you
might ask following the switch to SimpleOrderedMap. ("Hey I still see the
`NamedList` type in QueryResponse, why didn't the Suggest code change there as
well?"). But in hindsight I see why that comment reads like I'm saying this is
backwards-compatible. Sorry for the confusion.
To your other question, I might have interest in looking into ClusterInfo.
But if so, I'll probably punt it to a separate PR so that I can wait for
feedback on a [mailing list
thread](http://mail-archives.apache.org/mod_mbox/lucene-dev/202101.mbox/%3CCAPCX2-%2BuGBgagBWPeD8wT%3Dud9p3_cbWxW77vH1RPZqaNVpZXGA%40mail.gmail.com%3E)
that relates to all this (without holding up the Suggest code here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
