murblanc commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r559742269
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteCollectionCmd.java
##########
@@ -92,6 +98,19 @@ public void call(ClusterState state, ZkNodeProps message,
@SuppressWarnings({"ra
collection = extCollection;
}
+ PlacementPlugin placementPlugin =
ocmh.overseer.getCoreContainer().getPlacementPluginFactory().createPluginInstance();
Review comment:
Didn't dig into the details here, but when we delete a collection, we
should just check if there's another collection that defines `withCollection`
on it and refuse the delete based on that, no?
Just starting to look at the PR so maybe there's a reason for doing it this
way (in which case maybe adding a comment?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
