donnerpeter commented on a change in pull request #2229:
URL: https://github.com/apache/lucene-solr/pull/2229#discussion_r562493566
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -588,6 +585,12 @@ private boolean checkCondition(
return stems;
}
+ private boolean isFlagAppendedByAffix(int affixId, char flag) {
+ if (affixId < 0) return false;
Review comment:
In that case I'd also put braces (although I've seen people who don't).
But my case is "then-branch is a simple `return` on the same line". Are braces
also required in this case? And separate lines, like this?
```
if (affixId < 0) {
return;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
