jaisonbi commented on a change in pull request #2213:
URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r565127459
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java
##########
@@ -736,49 +736,92 @@ private void doAddSortedField(FieldInfo field,
DocValuesProducer valuesProducer)
private void addTermsDict(SortedSetDocValues values) throws IOException {
final long size = values.getValueCount();
meta.writeVLong(size);
- meta.writeInt(Lucene80DocValuesFormat.TERMS_DICT_BLOCK_SHIFT);
+ boolean compress =
+ Lucene80DocValuesFormat.Mode.BEST_COMPRESSION == mode
Review comment:
I didn't find a good solution to resolve this problem, since terms dict
compression could not be enabled by default currently.....there will be two
options:
1. introduce more configuration/mode. it will make things more complicated.
2. optimize BinaryDocValues compression.
We will try this feature in our cluster first, and see the actual
performance..so can we resolve this in another issue? or introduce more
configurations in this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
