madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568943853
########## File path: solr/core/src/test/org/apache/solr/cluster/VersionTrackerImpl.java ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cluster; + +import org.apache.solr.common.util.TimeSource; +import org.apache.solr.util.TimeOut; + +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; + +public class VersionTrackerImpl implements VersionTracker { + private int version = 0; + + @Override + public synchronized void increment() { + version++; + this.notifyAll(); + } + + @Override + public int waitForVersionChange(int currentVersion, int timeoutSec) throws InterruptedException, TimeoutException { + TimeOut timeout = new TimeOut(timeoutSec, TimeUnit.SECONDS, TimeSource.NANO_TIME); + int newVersion = currentVersion; + while (! timeout.hasTimedOut()) { Review comment: It's hard to do profiling on this since it generally only loops once on my machine, but I'll switch it to the loop inside of the block. It's part of the condition that we are implicitly checking with the wait, so it makes sense this way too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
