[ 
https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277959#comment-17277959
 ] 

Nazerke Seidan commented on SOLR-15124:
---------------------------------------

Thanks Mike for noticing the SolrCoreTest.testImplicitPlugins test which is 
failling now. I will update the PR.

> Remove node/container level admin handlers from ImplicitPlugins.json (core 
> level).
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-15124
>                 URL: https://issues.apache.org/jira/browse/SOLR-15124
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Blocker
>              Labels: newdev
>             Fix For: master (9.0)
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> There are many very old administrative RequestHandlers registered in a 
> SolrCore that are actually JVM / node / CoreContainer level in nature.  These 
> pre-dated CoreContainer level handlers.  We should (1) remove them from 
> ImplictPlugins.json, and (2) make simplifying tweaks to them to remove that 
> they work at the core level.  For example LoggingHandler has two constructors 
> and a non-final Watcher because it works in these two modalities.  It need 
> only have the one that takes a CoreContainer, and Watcher will then be final.
> /admin/threads
> /admin/properties
> /admin/logging
> Should stay because has core-level stuff:
> /admin/plugins
> /admin/mbeans
> This one:
> /admin/system -- SystemInfoHandler
> returns "core" level information, and also node level stuff.  I propose 
> splitting this one to a CoreInfoHandler to split the logic.  Maybe a separate 
> issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to