epugh commented on a change in pull request #2275:
URL: https://github.com/apache/lucene-solr/pull/2275#discussion_r570365526
##########
File path: solr/core/src/java/org/apache/solr/util/ExportTool.java
##########
@@ -216,32 +216,32 @@ void end() throws IOException {
Option.builder("url")
.hasArg()
.required()
- .desc("Address of the collection, example
http://localhost:8983/solr/gettingstarted";)
+ .desc("Address of the collection, example
http://localhost:8983/solr/gettingstarted.";)
Review comment:
Hey @madrob what do you think of my comments? I can go either way, or
not change it at all! Love to get these changes in soon.
##########
File path: solr/core/src/java/org/apache/solr/util/PackageTool.java
##########
@@ -261,44 +261,44 @@ protected void runImpl(CommandLine cli) throws Exception {
.argName("URL")
.hasArg()
.required(true)
- .desc("Address of the Solr Web application, defaults to: " +
SolrCLI.DEFAULT_SOLR_URL)
+ .desc("Address of the Solr Web application, defaults to: " +
SolrCLI.DEFAULT_SOLR_URL + '.')
.build(),
Option.builder("collections")
.argName("COLLECTIONS")
.hasArg()
.required(false)
- .desc("List of collections. Run './solr package help' for more
details.")
+ .desc("List of collections.")
.build(),
Option.builder("cluster")
.required(false)
- .desc("Needed to install cluster level plugins in a package. Run
'./solr package help' for more details.")
+ .desc("Needed to install cluster level plugins in a package.")
Review comment:
I see.. A package is a way of wrapping code up.. a plugin is anything
in Solr that is plugable. You can deploy a plugin via a package ;-=)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
