uschindler edited a comment on pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-775330463
I have to again look at the code, to figure out the best interaction that is still performant and clean to implement. So we don't convert too often between different XML API representations. I think the converter protected method should take a Source impl and return a new Source impl, in base class it just returns the parameter unmodified. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
