thelabdude commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582307325
##########
File path: api/v1beta1/solrcloud_types.go
##########
@@ -1022,3 +1040,37 @@ type SolrTLSOptions struct {
// +optional
RestartOnTLSSecretUpdate bool
`json:"restartOnTLSSecretUpdate,omitempty"`
}
+
+// +kubebuilder:validation:Enum=Basic
+type AuthenticationType string
+
+const (
+ Basic AuthenticationType = "Basic"
+)
+
+type SolrSecurityOptions struct {
+ // Indicates the authentication plugin type that is being used by Solr;
for now only "Basic" is supported by the
+ // Solr operator but support for other authentication plugins may be
added in the future.
+ AuthenticationType AuthenticationType
`json:"authenticationType,omitempty"`
Review comment:
I considered that and chose to make it required by the user to set to
`Basic` but I don't have strong feelings about enforcing that, will make
optional with default `Basic`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
