janhoy commented on pull request #2430: URL: https://github.com/apache/lucene-solr/pull/2430#issuecomment-786612766
> Do you think the WARN logic is EVEN useful since we have a parameter now that you have to intentionally set. I'm wondering what your thought is on removing the warning in the log? I'd probably skip testing that the logger actually logs. And given how this is documented, users should be aware of the risk. The only reason for keeping the WARN log would be in cases where settings from dev/test environments sneak into production unaware. But then again, if the production IDP server is setup with HTTPS, it would immediately fail if trying a HTTP URL... My gut feeling is keep it securey by default, make it easy to switch to insecure for dev and that's it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
