rmuir commented on pull request #2434: URL: https://github.com/apache/lucene-solr/pull/2434#issuecomment-787047833
I'm kind of opposed to convenience methods in BytesRef/IntsRef etc at all. Trust me, with almost every patch someone wants to add a new one, with inconsistent behavior. Had to go in and clean house multiple times, it is extremely painful. I wish we could "freeze" these classes so ppl just would stop trying to modify them to save a line of code here or there. That being said, there is a `BytesRef(byte[])`. But I see no `Charsref(char[])`. So I'm uncertain about `IntsRef(int[])` because it still leaves things inconsistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
