donnerpeter commented on a change in pull request #4:
URL: https://github.com/apache/lucene/pull/4#discussion_r591650945
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##########
@@ -60,9 +63,15 @@
String word, WordCase originalCase) {
Comparator<Weighted<Root<String>>> natural = Comparator.naturalOrder();
PriorityQueue<Weighted<Root<String>>> roots = new
PriorityQueue<>(natural.reversed());
- List<Root<String>> entries = new ArrayList<>();
Review comment:
We don't allocate Root now until we're sure they're suitable, and then
we add them directly to the PriorityQueue above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
