rmuir commented on pull request #34: URL: https://github.com/apache/lucene/pull/34#issuecomment-804606020
ok, I think ecj linter is now in better shape, especially as far as dead code goes. But wow, the amount of dead `private` members and methods that we had was really surprising. We should followup by enabling the check to enforce `@Override` annotations, so that when public/protected methods get removed, dangling bits aren't left around. That's a good way to improve it to the future. But, another issue. I am tired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
