gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r600513254
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+ private void indexDrillDownTerms(
+ Document doc, String indexFieldName, DimConfig ft, FacetLabel cp) {
Review comment:
Does anyone know what "ft" and "cp" actually stand for? Is this a case
where the class names changed at some point but the variable names stayed the
same? I dunno. Either way, is it time to maybe name these something more
descriptive in this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
