[
https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308540#comment-17308540
]
Uwe Schindler commented on LUCENE-9864:
---------------------------------------
Especially the missing overrides at beginning of file in the tartarus-snowball
packages need to be patched in the regneration task of gradle.
IMHO, we should really make sure that we add some "autogen marker comment
header" on all autogenerated files and maybe add some check in our source code
checks, that files are not accidentally updated by autoreformatting/fixup by
IDE code. One idea would be: All regeneration taks add some header on top of
the file with a checksum. In precommit we check that the hash in the header
still applies to the remaining file contents. We can maybe also add a sha1/md5
file next to each regenerated file that is solely updated on regeneration.
> Enforce @Override annotation with ecj static analysis configuration
> -------------------------------------------------------------------
>
> Key: LUCENE-9864
> URL: https://issues.apache.org/jira/browse/LUCENE-9864
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Zach Chen
> Priority: Minor
> Labels: build
> Fix For: main (9.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin-off issue from
> https://issues.apache.org/jira/browse/LUCENE-9856, where ecj configuration
> was updated to catch dead code and lots of dead code was removed. In this
> issue, we would like to continue the clean up by enforcing *@Override* usage
> with *org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error*
> configuration, and fix problems that arise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
