rmuir commented on pull request #40: URL: https://github.com/apache/lucene/pull/40#issuecomment-807558073
> I wondered whether it makes sense to cherry pick those template commits, regenerate, then rebase this patch but maybe it's form over function. In the end it's going to be the same. +1 to commit from me. I would never do it this way, because I don't think it makes sense to push commits that change generated code for seemingly no reason? You really need the new check, to know that you did it thoroughly and correctly. Plus: I don't use `git rebase` :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
