dweiss commented on a change in pull request #80:
URL: https://github.com/apache/lucene/pull/80#discussion_r612178745



##########
File path: gradle/generation/snowball.gradle
##########
@@ -114,5 +133,5 @@ configure(project(":lucene:analysis:common")) {
     }
   }
 
-  regenerate.dependsOn mustRunInOrder([snowball, "spotlessApply"])
+  regenerate.dependsOn wrapWithPersistentChecksums(snowball, [ andThenTasks: 
"spotlessApply", ignoreWithSource: [downloadSnowballStemmers, 
downloadSnowballWebsite, downloadSnowballData] ])

Review comment:
       Maybe we can do a trivial change of suffixing the names of wrapped tasks 
"*Internal" and then strip this suffix for the wrapper (instead of appending 
"IfNeeded")... This would make those wrapped tasks more intuitive in isolated 
calls?... 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to