[
https://issues.apache.org/jira/browse/LUCENE-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335265#comment-17335265
]
Alan Woodward commented on LUCENE-9204:
---------------------------------------
So there are a few things that need to be done here, because Spans reuse some
of the two-phase conjunction and disjunction logic. It can all be done as a
single PR but it might make sense to split things out into smaller tickets? Or
multiple PRs attached to this ticket maybe.
* Duplicate ConjunctionDISI and add a package-private version in the spans
package. We should be able to make the standard impl package-private at this
point as well
* Duplicate DisiWrapper/DisiPriorityQueue/DisjunctionDISI and add a
package-private version in the spans package. This will make three copies of
this code (there's one for intervals as well) which suggests that we may be
able to generify it a bit, but it's also on the hot path for queries so maybe
we just live with the duplication.
* Actually move all the spans code and move those tests that rely on spans into
queries/tests. Some of these can be turned into base test classes - for
example the Matches test class has a lot of methods which could be moved to
test-framework and then the span test cases can be added to a new suite in
queries.
> Move span queries to the queries module
> ---------------------------------------
>
> Key: LUCENE-9204
> URL: https://issues.apache.org/jira/browse/LUCENE-9204
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
>
> We have a slightly odd situation currently, with two parallel query
> structures for building complex positional queries: the long-standing span
> queries, in core; and interval queries, in the queries module. Given that
> interval queries solve at least some of the problems we've had with Spans, I
> think we should be pushing users more towards these implementations. It's
> counter-intuitive to do that when Spans are in core though. I've opened this
> issue to discuss moving the spans package as a whole to the queries module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
