gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r624557991
##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -140,41 +139,6 @@ subprojects {
}
}
- // Verifies that each JAR has a corresponding checksum and that it matches
actual JAR available for this dependency.
- task validateJarChecksums() {
Review comment:
Hmmm. I don't think gradle exposes the task that it uses for checksum
validation. I peeked at the original
[plugin](https://github.com/vlsi/vlsi-release-plugins/blob/master/plugins/checksum-dependency-plugin/README.md)
that inspired this feature in gradle and that plugin too does not expose this..
As a side note: That plugin has some functionality for checking the license
type (we currently have custom logic for this).
##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, validateJarLicenses
+ licenses.dependsOn validateJarLicenses
}
// Add top-project level tasks validating dangling files
// and regenerating dependency checksums.
configure(project(":lucene")) {
def validationTasks = subprojects.collectMany { it.tasks.matching { it.name
== "licenses" } }
- def jarInfoTasks = subprojects.collectMany { it.tasks.matching { it.name ==
"collectJarInfos" } }
-
- // Update dependency checksums.
- task updateLicenses() {
Review comment:
The mistake here was that we were only generating checksums for the
dependencies and plugins that `help` or `updateLicenses` tasks use. The
`./gradlew --write-verification-metadata sha256 check` command records all
dependencies used by the `check` task. Fixing this makes `./gradlew check` work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
