[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-9843:
--------------------------------
Attachment: LUCENE-9843.patch
mods.patch
Status: Open (was: Open)
[~jdconradson] I played with the patch and found some more code that could be
removed now that terms dict compression is no longer conditional.
For example we no longer need to write a special code in the metadata to
indicate terms dict is compressed anymore, terms dict block shift amounts can
just be constants, and some {{if (compressed) }} conditionals can go away.
I uploaded a new {{LUCENE-9843.patch}} and a smaller {{mods.patch}} just
showing what i changed from your patch.
> Remove compression option on doc values
> ---------------------------------------
>
> Key: LUCENE-9843
> URL: https://issues.apache.org/jira/browse/LUCENE-9843
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Blocker
> Attachments: LUCENE-9843.patch, LUCENE-9843.patch, LUCENE-9843.patch,
> mods.patch
>
>
> Options on file formats add complexity and put a big tax on
> backward-compatibility testing. I'm the one who introduced it LUCENE-9378 but
> I would now like to think about what we can do to remove this option.
> For the record, compression was initially introduced because some binary
> fields have so much redundancy that it's wasteful not to compress them at
> all. But unfortunately, this slowed down some search workloads and we decided
> to introduce this option as a way to let users choose the trade-off they want.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
