[
https://issues.apache.org/jira/browse/LUCENE-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344521#comment-17344521
]
Adrien Grand edited comment on LUCENE-9958 at 5/14/21, 11:20 AM:
-----------------------------------------------------------------
Good news is that it's easy to reproduce. Using the following tasks file
{noformat}
MSM1: ref http from mostly interview 9 hard
MSM2: ref http from mostly interview 9 hard +minShouldMatch=2
MSM3: ref http from mostly interview 9 hard +minShouldMatch=3
MSM4: ref http from mostly interview 9 hard +minShouldMatch=4
MSM5: ref http from mostly interview 9 hard +minShouldMatch=5
MSM6: ref http from mostly interview 9 hard +minShouldMatch=6
MSM7: ref http from mostly interview 9 hard +minShouldMatch=7
{noformat}
I got the following results on wikimedium10m where baseline is origin/main and
the patch reverts LUCENE-9346:
{noformat}
TaskQPS baseline StdDev QPS patch StdDev
Pct diff p-value
MSM2 20.22 (3.7%) 1.94 (0.2%)
-90.4% ( -90% - -89%) 0.000
MSM3 20.14 (3.7%) 3.00 (0.7%)
-85.1% ( -86% - -83%) 0.000
MSM4 18.95 (3.6%) 8.81 (2.5%)
-53.5% ( -57% - -49%) 0.000
PKLookup 250.33 (3.5%) 230.62 (3.7%)
-7.9% ( -14% - 0%) 0.000
MSM7 202.13 (4.2%) 199.17 (3.3%)
-1.5% ( -8% - 6%) 0.216
MSM1 20.24 (3.7%) 20.81 (3.3%)
2.9% ( -4% - 10%) 0.010
MSM5 5.04 (5.5%) 29.43 (33.8%)
483.5% ( 420% - 553%) 0.000
MSM6 2.28 (6.1%) 90.03 (298.1%)
3852.9% (3343% - 4428%) 0.000
{noformat}
was (Author: jpountz):
Good news is that it's easy to reproduce. Using the following tasks file
{noformat}
MSM1: ref http from mostly interview 9 hard
MSM2: ref http from mostly interview 9 hard +minShouldMatch=2
MSM3: ref http from mostly interview 9 hard +minShouldMatch=3
MSM4: ref http from mostly interview 9 hard +minShouldMatch=4
MSM5: ref http from mostly interview 9 hard +minShouldMatch=5
MSM6: ref http from mostly interview 9 hard +minShouldMatch=6
MSM7: ref http from mostly interview 9 hard +minShouldMatch=7
{noformat}
I got the following results on wikimedium10m where baseline is origin/main and
the patch reverts LUCENE-9346:
{noformat}
TaskQPS baseline StdDev QPS patch StdDev
Pct diff p-value
PKLookup 248.06 (3.6%) 231.47 (4.3%)
-6.7% ( -14% - 1%) 0.000
MSM7 182.44 (3.8%) 181.65 (3.4%)
-0.4% ( -7% - 7%) 0.704
MSM1 19.52 (4.4%) 20.31 (3.8%)
4.1% ( -4% - 12%) 0.002
MSM2 3.27 (3.4%) 4.20 (2.9%)
28.4% ( 21% - 35%) 0.000
MSM3 3.09 (4.6%) 6.95 (4.9%)
125.0% ( 110% - 141%) 0.000
MSM4 2.29 (5.7%) 9.85 (15.2%)
329.9% ( 292% - 371%) 0.000
MSM5 2.20 (5.8%) 29.48 (56.8%)
1240.2% (1113% - 1382%) 0.000
MSM6 2.21 (5.8%) 88.95 (223.7%)
3929.4% (3497% - 4414%) 0.000
{noformat}
> Performance regression when a minimum number of matching SHOULD clauses is
> required
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-9958
> URL: https://issues.apache.org/jira/browse/LUCENE-9958
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Priority: Minor
>
> Opening this issue on behalf of [~mattweber], who reported this at
> https://discuss.elastic.co/t/es-7-7-1-es-7-12-0-wand-performance-issue/272854.
> It looks like the fact that we introduced dynamic pruning for queries that
> already have a minimum number of SHOULD clauses configured makes things
> _slower_, at least in some cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
